1
68%
master: 68%

Ran 02 May 2018 10:43PM UTC

Files 55

Run time 3s

Badge

Embed ▾

Committed 02 May 2018 10:08PM UTC coverage: 67.679% (+0.06%) from 67.621%

Job # 687.1

Build Type

Pull #256

travis-ci

Committed by

web-flow

Commit Message

fix(API): Pass null-terminated char* to driver

This fixes an Ascii decoding bug in the following three properties:

* DatabaseObject.comment
* Frames.set_session_j1939_addr_filter
* Interface.src_term_start_trigger

When using these property setters, we were passing
a char* without null termination to the driver.
Then, when reading these properties with the
getter, we'd get our string back with non-Ascii
characters on the end, which caused an exception
when trying to decode to Ascii.

In the cprops layer for these properties,
we converted strings to a char* using
create_string_buffer with a length argument,
which results in copying over the python
string into the buffer without a null terminator.

Other places in the _funcs.py would just convert
the python strings to a char_p before passing to
the driver, and doing this doesn't guarantee a
null-terminted char*.

The best strategy for converting python strings
to a null-terminated char* is to use
create_string_buffer without a length argument.

Pull Request Pull Request #256: fix(API): Pass null-terminated char* to driver

Coverage Stats

4680 of 6915 relevant lines covered (67.68%)

0.68 hits per line

ni / nixnet-python / 687 / 1
68%
master: 68%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 687.1

ni / nixnet-python / 687 / 1 68% master: 68%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 687.1

ni / nixnet-python / 687 / 1
68%
master: 68%

README BADGES
x