9
66%
master: 66%

Ran 10 Apr 2018 06:45PM UTC

Files 85

Run time 5s

Badge

Embed ▾

Committed 10 Apr 2018 06:28PM UTC coverage: 62.484% (+0.1%) from 62.356%

Job # RUN="coverage"

Build Type

push

travis-ci

Committed by

rolandshoemaker

Commit Message

RA: Don't lose CA error types when prefixing err msg. (#3633)

Previously we updated the RA's issueCertificateInner function to prefix errors returned from the CA with meaningful information about which CA RPC caused the failure. Unfortunately by using fmt.Errorf to do this we're discarding the underlying error type. This can cause unexpected server internal errors downstream if (for e.g.) the CA rejects a CSR with a malformed error (see #3632).

This PR updates the issueCertificateInner error message prefixing to maintain the error type if the underlying error is a berrors.BoulderError. A RA unit test with several mock CAs is added to test the prefixing occurs as expected without loss of error type.

This PR also adds an integration test that ensures we reject a CSR with >100 names with a malformed error. This is not strictly related to this PR but since I wrote it while debugging the root issue I thought I'd include it. To allow this test to pass the pendingAuthorizationsPerAccount in test/rate-limit-policies.yml and associated tests had to be adjusted.

Resolves #3632

Coverage Stats

9920 of 15876 relevant lines covered (62.48%)

0.69 hits per line

letsencrypt / boulder / 8981 / 9
66%
master: 66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 8981.9 (RUN="coverage")

letsencrypt / boulder / 8981 / 9 66% master: 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 8981.9 (RUN="coverage")

letsencrypt / boulder / 8981 / 9
66%
master: 66%

README BADGES
x