3
80%
master: 80%

Ran 04 Apr 2018 04:25PM UTC

Files 397

Run time 15s

Badge

Embed ▾

Committed 04 Apr 2018 03:55PM UTC coverage: 19.979% (+0.004%) from 19.975%

Job # BUILD_METHOD=opam-coverage

Build Type

push

travis-ci

Committed by

mseri

Commit Message

CA-286364: When creating guest_metrics, ensure all fields reflect current state

In CA-286364, a reboot happened on a VM that had PV tools installed. This
triggered xapi's updates-from-xenopsd to look at the new state. This was slow
for other reasons and by the time we were looking at the events the VM had
reloaded its PV drivers.

When we notice a VM has a different start time we delete and recreate the guest
metrics. This object was, prior to this change, created with `PV_drivers_detected`
taking the default value of `false`.

We then took a look at the value of 'PV_drivers_detected' in the current state
of the VM and noticed that it hadn't changed since we last looked at it (before
the VM rebooted) - so we didn't set the field in the database.

The change in this CS ensures we always create the guest_metrics with the current
state of the VM, which we were already doing for all other fields in
`VM_guest_metrics`.

Signed-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>

Run Details

19506 of 97634 relevant lines covered (19.98%)

2254.11 hits per line

xapi-project / xen-api / 4891 / 3
80%
master: 80%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4891.3 (BUILD_METHOD=opam-coverage)

xapi-project / xen-api / 4891 / 3 80% master: 80%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4891.3 (BUILD_METHOD=opam-coverage)

xapi-project / xen-api / 4891 / 3
80%
master: 80%

README BADGES
x