1
72%
master: 72%

Ran 04 Apr 2018 01:58PM UTC

Files 401

Run time 14s

Badge

Embed ▾

Committed 04 Apr 2018 01:58PM UTC coverage: 72.403% (-0.04%) from 72.442%

Job # 42.1

Build Type

push

jenkins

Committed by Sijie Guo

Commit Message

longPollThreadPool can not be null

Descriptions of the changes in this PR:

*Problem*

The long polling logic is built with the assumption that there is a thread pool for scheduling deferred reads.
So if people happens to set `numLongPollWorkerThreads` to zero or negative, a null value is passed into long poll requests which causes NPE.

*Solution*

If `numLongPollWorkerThreads` is set to zero or negative, fall back to use read thread pool. If there is no read thread pool, create a thread pool
aligned with num processors.

With this change, turn the default value of `long poll threads` to zero. so no additional threads are needed if long poll feature is not used (e.g. at pulsar).

Author: Sijie Guo <sijie@apache.org>

Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Yiming Zang <yzang2016@gmail.com>, Matteo Merli <mmerli@apache.org>

This closes #1308 from sijie/validate_number_long_poll_threads

Coverage Stats

23069 of 31862 relevant lines covered (72.4%)

0.72 hits per line

apache / bookkeeper / 42 / 1
72%
master: 72%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 42.1

apache / bookkeeper / 42 / 1 72% master: 72%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 42.1

apache / bookkeeper / 42 / 1
72%
master: 72%

README BADGES
x