1
98%
master: 98%

Ran 04 Apr 2018 12:39PM UTC

Files 1

Run time 0s

Badge

Embed ▾

Committed 04 Apr 2018 12:37PM UTC coverage: 95.238% (-2.4%) from 97.619%

Job # 21.1

Build Type

Pull #14

travis-ci

Committed by

web-flow

Commit Message

Always separate on spaces and unprintable characters

Some code is sending our backend mentions with a zero-width joiner for
whatever reason, for example:

    @example\u200d skldjg

The mention that would would get picked up is `@example\u200d`, instead
of the expected `@example`.

This patch always treats spaces and unprintable characters as
a terminator. I'm not sure if it ever makes sense to use a space inside
a mention?

Alternatively, I could add a callback function, or something?
Maintaining a list of all space/unprintable characters doesn't strike me
as a good idea, and the `unicode.Is*()` functions contain some
performance optimisations for the common (non-multibyte) use cases.

The downside is some performance loss:

master:

    BenchmarkGetTags-4       2000000               950 ns/op

this:

    BenchmarkGetTags-4       1000000              1312 ns/op

Pull Request Pull Request #14: Always separate on spaces and unprintable characters

Run Details

40 of 42 relevant lines covered (95.24%)

197.83 hits per line

gernest / mention / 21 / 1
98%
master: 98%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 21.1

gernest / mention / 21 / 1 98% master: 98%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 21.1

gernest / mention / 21 / 1
98%
master: 98%

README BADGES
x