uber-go / cadence-client / 730 / 1
65%
master: 65%

DEFAULT BRANCH: master
Ran
Files 29
Run time 3s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 64.852% (+0.1%) from 64.721%
730.1

push

travis-ci

vancexu 
Actually detect the existing lint failures (#430)

Currently, `make lint` doesn't detect any problems, apparently because
`golint internal/activity.go` doesn't report any issues.
However, if you `golint internal` you get multiple results, and you get
the same if you `golint internal/activity.go internal/other_files.go`.

Why fails like this, I have no idea.

The fix though is to call `golint` with a whitelisted set of go files,
per directory (on the assumption that every directory is a package).
Make doesn't make this particularly easy, but it's at least possible.

```
$ make lint
./internal/activity.go:186:9: should not use basic type untyped string as key in context.WithValue
./internal/activity_test.go:48:8: should not use basic type untyped string as key in context.WithValue
./internal/activity_test.go:66:8: should not use basic type untyped string as key in context.WithValue
./internal/activity_test.go:85:8: should not use basic type untyped string as key in context.WithValue
./internal/activity_test.go:103:8: should not use basic type untyped string as key in context.WithValue
./internal/activity_test.go:121:8: should not use basic type untyped string as key in context.WithValue
./internal/activity_test.go:136:8: should not use basic type untyped string as key in context.WithValue
./internal/activity_test.go:149:8: should not use basic type untyped string as key in context.WithValue
./internal/activity_test.go:179:8: should not use basic type untyped string as key in context.WithValue
./internal/internal_task_pollers.go:352:9: should not use basic type untyped string as key in context.WithValue
Found 10 lint suggestions; failing.
make: *** [lint] Error 1
```

5456 of 8413 relevant lines covered (64.85%)

113.58 hits per line

Source Files on job 730.1