caicloud / nirvana / 577 / 2
46%
master: 46%

DEFAULT BRANCH: master
Ran
Files 66
Run time 2s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 60.059% (-0.2%) from 60.25%
577.2

push

travis-ci

caicloud-bot 
feat(config): add PreConfigure and PostConfigure hooks (#190)

Automatic merge from submit-queue.

feat(config): add PreConfigure and PostConfigure hooks

**What this PR does / why we need it**:

Add PreConfigure and PostConfigure hooks.
After creating nirvana server, config becomes immutable. So we need the two hooks.

**Which issue(s) this PR fixes** *(optional, close the issue(s) when PR gets merged)*:

Fixes #

**Special notes for your reviewer**:

/cc @caitong93 
/cc @zoumo 

**Release note**:


```release-note
Add PreConfigure and PostConfigure hooks
```

<!--  Thanks for sending a pull request! Here are some tips:

1. https://github.com/caicloud/engineering/blob/master/docs/review_conventions.md  <-- what is the review process looks like
2. https://github.com/caicloud/engineering/blob/master/docs/commit_conventions.md  <-- how to structure your git commit
3. https://github.com/caicloud/engineering/blob/master/docs/caicloud_bot.md        <-- how to work with caicloud bot

Other tips from Kubernetes cmomunity:

1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide
2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews
3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed
4. If the PR is unfinished, see how to mark it: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#marking-unfinished-pull-requests
-->

3036 of 5055 relevant lines covered (60.06%)

24.99 hits per line

Source Files on job 577.2