11
97%
master: 97%

Ran 25 Mar 2018 11:58PM UTC

Files 37

Run time 1s

Badge

Embed ▾

Committed 25 Mar 2018 11:47PM UTC coverage: 0.0%. Remained the same

Job # jruby-head, SUITE=rspec spec

Build Type

Pull #389

travis-ci

Committed by

web-flow

Commit Message

Avoid calling content_security_policy_nonce internally

Rails 5.2 adds support for configuring a Content-Security-Policy header,
including adding nonces to tags produced by the `javascript_tag` helper.

Unfortunately, Rails and this gem now both define a helper named
`content_security_policy_nonce`:

https://github.com/rails/rails/blob/v5.2.0.rc2/actionpack/lib/action_controller/metal/content_security_policy.rb#L44
https://github.com/twitter/secureheaders/blob/v5.0.5/lib/secure_headers/view_helper.rb#L69

The Rails helper wins over the Secure Headers one, and helpers like
`nonced_javascript_tag` currently raise this error on Rails 5.2:

    ArgumentError: wrong number of arguments (given 1, expected 0)

By using a method with a different name internally, we avoid clashing
with the Rails implementation, and `nonced_javascript_tag` works again.

Pull Request Pull Request #389: Avoid calling content_security_policy_nonce internally

Run Details

0 of 2110 relevant lines covered (0.0%)

0.0 hits per line

twitter / secureheaders / 1167 / 11
97%
master: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1167.11 (jruby-head, SUITE=rspec spec)

twitter / secureheaders / 1167 / 11 97% master: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1167.11 (jruby-head, SUITE=rspec spec)

twitter / secureheaders / 1167 / 11
97%
master: 97%

README BADGES
x