1
72%
master: 72%

Ran 25 Mar 2018 01:53PM UTC

Files 396

Run time 10s

Badge

Embed ▾

Committed 25 Mar 2018 01:53PM UTC coverage: 72.458% (+0.01%) from 72.445%

Job # 32.1

Build Type

push

jenkins

Committed by Sijie Guo

Commit Message

Refactored logAndConvertStatus() to avoid allocation when debug is off

The method `logAndConvertStatus(StatusCode status, int defaultStatus, Object... extraInfo)` is being called when processing the response for each write/read request in `PerChannelBookieClient`.

The logging is only done at debug level and the `extraInfo` is not used otherwise. By taking the `Object...` we're effectively taking a `Object[]` that is allocated each time, along with the boxing for ledgerId/entryId.

Refactored the code separate the logging and the status code conversion, so that we can skip the allocation when debug is off.

Author: Matteo Merli <mmerli@apache.org>

Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Sijie Guo <sijie@apache.org>

This closes #1291 from merlimat/log-and-convert-status

Run Details

23001 of 31744 relevant lines covered (72.46%)

0.72 hits per line

apache / bookkeeper / 32 / 1
72%
master: 72%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 32.1

apache / bookkeeper / 32 / 1 72% master: 72%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 32.1

apache / bookkeeper / 32 / 1
72%
master: 72%

README BADGES
x