3
100%
master: 100%

Ran 22 Mar 2018 09:37AM UTC

Files 8

Run time 0s

Badge

Embed ▾

Committed 22 Mar 2018 09:33AM UTC coverage: 100.0%. Remained the same

Job # TOX_ENV=cov-travis

Build Type

push

travis-ci

Committed by

bors[bot]

Commit Message

Merge #44

44: Always give a timeout to thread join, to avoid uninterruptible sleep r=rohanpm a=rohanpm

In Python 2.x, a thread join with no timeout is uninterruptible.
This means a process could get stuck in executor shutdown such that
the process can't be killed by SIGTERM.  That's undesirable;
provide a timeout so that it's possible to interrupt.

Python 3 doesn't have this problem (tested on 3.6) - thread joins
are interruptible there.

This probably doesn't entirely fix the problem for Python 2, for
example ThreadPoolExecutor can probably still hang uninterruptably
at shutdown, but at least my code won't be contributing to the
problem...

Fixes #42

Run Details

503 of 503 relevant lines covered (100.0%)

1.0 hits per line

rohanpm / more-executors / 168 / 3
100%
master: 100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 168.3 (TOX_ENV=cov-travis)

rohanpm / more-executors / 168 / 3 100% master: 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 168.3 (TOX_ENV=cov-travis)

rohanpm / more-executors / 168 / 3
100%
master: 100%

README BADGES
x