6
66%
master: 66%

Ran 18 Mar 2018 01:20AM UTC

Files 85

Run time 3s

Badge

Embed ▾

Committed 16 Mar 2018 08:42PM UTC coverage: 62.091%. Remained the same

Job # RUN="coverage"

Build Type

cron

travis-ci

Committed by

rolandshoemaker

Commit Message

Harmonize order expiry with assoc. authz expiry. (#3567)

Prior to this commit an order's expiry was set based on
ra.orderLiftime while pending and valid authorization expiry was set
based on ra.pendingAuthorizationLifetime and
ra.authorizationLifetime. Since orders reused existing valid/pending
authorizations this can lead to a case where an order has an expiry
beyond the associated authorization expiries. In this case when an
authorization expired the order becomes inactionable and the extra order
lifetime is not useful.

This commit addresses this problem in two ways:

1. The SA GetAuthorizations function used to find authzs to reuse for
ra.NewOrder is adjusted to only return authorizations at min 24hr
away from expiry.
2. Order expiry is now calculated by the RA in newOrder
as the min of the order's own expiry or the soonest
authorization expiry. This properly reflects the order's true
lifetime based on the authorization lifetime.

The RA/SA unit tests are updated accordingly.

Resolves #3498

Coverage Stats

9765 of 15727 relevant lines covered (62.09%)

0.69 hits per line

letsencrypt / boulder / 8865 / 6
66%
master: 66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 8865.6 (RUN="coverage")

letsencrypt / boulder / 8865 / 6 66% master: 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 8865.6 (RUN="coverage")

letsencrypt / boulder / 8865 / 6
66%
master: 66%

README BADGES
x