SOHU-Co / kafka-node / 721 / 11

89%

master: 89%

push

travis-ci

auto commit and add event for rebalance (#889)

* auto commit and add event for rebalance

Should resolve #787

If auto commit is true, commit before we rejoin the group on a rebalance
According to the kafka protcol, commits are allowed during this stage, as the generation ID has not been bumped yet.

If auto commit is disabled, implementors need a way to decide what to commit, so an onRebalance option was added.

Implementors can perform commits during this method and call back when done to finish the rebalance.

* Auto commit on ConsumerGroupStream during rebalance too

This required special behavior due to the separate commit queue

* Actually shouldn't be checking the autoCommit setting for CGS

commit(null, true) will flush what was already in the queue.

* Bubble errors from user defined callback up, and cancel saving

* use ._once instead of manual flag checking

1067 of 1442 branches covered (73.99%)

3389 of 3887 relevant lines covered (87.19%)

6915.06 hits per line