1
36%
master: 36%

Ran 08 Mar 2018 02:55AM UTC

Files 738

Run time 24s

Badge

Embed ▾

Committed 08 Mar 2018 02:55AM UTC coverage: 44.935% (+0.05%) from 44.887%

Job # 952.1

Build Type

push

travis-ci

Committed by Tadeusz Struk

Commit Message

tcti: Refactor the return paths in the 'receive' functions.

The initial implementation had every return path from this function
`goto` the label at the end of the function. Some of these cases were
returning some form of 'success' while others were errors. This required
a conditional after the label to check to see whether the state of the
TCTI should transition to the TRANSMIT state or whether it should remain
in the RECEIVE state so that the user can attempt to get the response
again.

This conditional at the end of the function is unusual and by defying
convention it causes confusion for developers. This commit re-works the
return paths from the Receive functions in both TCTI such that the label
at the end of the function represents the code path taken when the TCTI
should be transitioned to the TRANSMIT state. All other code paths
return directly by using the `return` statement.

Functionally the two approaches are equivalent but this new strategy is
easier to read.

Signed-off-by: Philip Tricca <philip.b.tricca@intel.com>

Run Details

10628 of 23652 relevant lines covered (44.93%)

38.62 hits per line

tpm2-software / tpm2-tss / 952 / 1
36%
master: 36%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 952.1

tpm2-software / tpm2-tss / 952 / 1 36% master: 36%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 952.1

tpm2-software / tpm2-tss / 952 / 1
36%
master: 36%

README BADGES
x