1
31%
master: 64%

Ran 02 Mar 2018 07:52AM UTC

Files 211

Run time 8s

Badge

Embed ▾

Committed 02 Mar 2018 07:52AM UTC coverage: 66.376% (-0.1%) from 66.504%

Job # TR_ARCH=local GCOV=1

Build Type

push

travis-ci

Committed by Andrei Vagin

Commit Message

x86/kdat: Check PTRACE_TRACEME return value

Coverity has informed:

*** CID 188251:  Error handling issues  (CHECKED_RETURN)
/criu/arch/x86/crtools.c: 196 in kdat_x86_has_ptrace_fpu_xsave_bug_child()
190             return 0;
191     }
192     #endif
193
194     static int kdat_x86_has_ptrace_fpu_xsave_bug_child(void *arg)
195     {
>>>     CID 188251:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "ptrace" without checking return value (as is done elsewhere 46 out of 51 times).
196             ptrace(PTRACE_TRACEME, 0, 0, 0);
197             kill(getpid(), SIGSTOP);
198             pr_err("Continue after SIGSTOP.. Urr what?\n");
199             _exit(1);
200     }
201

Also added checks for kill() and waitpid().

Signed-off-by: Dmitry Safonov <dima@arista.com>
Signed-off-by: Andrei Vagin <avagin@virtuozzo.com>

Coverage Stats

19910 of 29996 relevant lines covered (66.38%)

715437.24 hits per line

avagin / criu / 2632 / 1
31%
master: 64%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2632.1 (TR_ARCH=local GCOV=1)

avagin / criu / 2632 / 1 31% master: 64%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2632.1 (TR_ARCH=local GCOV=1)

avagin / criu / 2632 / 1
31%
master: 64%

README BADGES
x