1
0%
master: 0%

Ran 16 Feb 2018 07:35PM UTC

Files 8

Run time 0s

Badge

Embed ▾

Committed 16 Feb 2018 07:30PM UTC coverage: 0.0%. First build

Job # 464.1

Build Type

push

travis-ci

Committed by

lencioni

Commit Message

Replace object spread with Set in generateCSSRuleset

I was profiling Aphrodite and noticed that the self time in
generateCSSRuleset is one of the most expensive bits. Digging in a bit,
it looked like most of this was coming from the object spread here,
which we use do copy the original object so we can reference its keys
with fast lookups. By swapping this out for a Set we greatly reduce the
self time of this function from ~7% of total runtime to ~3%.

I've implemented this in a way that expects Set to be available in the
browser or polyfilled, which I think is a reasonable explanation. I've
documented this in the readme. If we move forward with this, we could
also make Map a requirement and simplify a couple of codepaths if we
want.

Run Details

0 of 0 relevant lines covered (NaN%)

0.0 hits per line

Khan / aphrodite / 464 / 1
0%
master: 0%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 464.1

Khan / aphrodite / 464 / 1 0% master: 0%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 464.1

Khan / aphrodite / 464 / 1
0%
master: 0%

README BADGES
x