1
94%
master: 94%

Ran 08 Feb 2018 04:39AM UTC

Files 92

Run time 3s

Badge

Embed ▾

Committed 08 Feb 2018 04:35AM UTC coverage: 91.74% (-0.2%) from 91.987%

Job # 4125.1

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

[#749] Storage layer needs proper error handling (#816)

XmlSerializableAddressBook does not have a method to convert itself to
an AddressBook object. It implements ReadOnlyAddressBook and has
getPersonList() and getTagList() methods, which the caller uses to
create an AddressBook object.

By implementing ReadOnlyAddressBook, the overridden getPersonList()
and getTagList() methods are unable to throw IllegalValueException to
higher level components for error handling if there's errors in the
.xml save file.

Let's implement a toModelType() method in XmlSerializableAddressBook
to allow the XmlSerializableAddressBook to convert itself to an 
AddressBook and remove it's implementation of ReadOnlyAddressBook.
Let's also override the equals(Object) method in XmlAdaptedPerson,
XmlAdaptedTag and XmlSerializableAddressBook

Run Details

1455 of 1586 relevant lines covered (91.74%)

0.92 hits per line

se-edu / addressbook-level4 / 4125 / 1
94%
master: 94%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4125.1

se-edu / addressbook-level4 / 4125 / 1 94% master: 94%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4125.1

se-edu / addressbook-level4 / 4125 / 1
94%
master: 94%

README BADGES
x