apollographql / graphql-tools / 1770 / 5

94%

master: 94%

push

travis-ci

fix(subscriptions): The subscription resolvers were firing too often (#609)

* fix(subscriptions): The subscription resolvers were firing too often

The underlying subscription in a remote schema was not terminated properly, causing memory leaks. In
addition, multiple subscriptions caused duplicate payloads. Both is fixed by removing the PubSub
dependency and directly transforming the Observer returned by the ApolloLink to an async iterable.
This allows the async iterable to propagate to the underlying observable to cancel the suscription
once the subscription is not needed anymore.

* refactor(test): remove timeout from test

* chore(changelog): add fix to changelog

583 of 663 branches covered (87.93%)

1158 of 1237 relevant lines covered (93.61%)

94.26 hits per line