• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

curationexperts / mahonia / 1039 / 1
98%
master: 98%

Build:
Build:
LAST BUILD BRANCH: rubocop
DEFAULT BRANCH: master
Ran 27 Jan 2018 12:55AM UTC
Files 52
Run time 32s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

27 Jan 2018 12:45AM UTC coverage: 56.549% (-41.3%) from 97.841%
2.4.2

push

travis-ci

no-reply
Add basic virus checking with logging and file deletion

Virus handling is added to `AttachFilesToWorkJob` (which unfortunately must be
copied wholesale from Hyrax).

By default Hyrax embeds virus checking in the model validations, which means a
real `Hydra::PCDM::File` must exist in order to check for a virus and handle
errors. This is somewhat challenging in the case that we want to check
asynchonously and handle errors, since a `File` doesn't exist until an
`ImportJob` is running; in the default actor stack, this is several asynchonous
jobs deep.

By adding an early check, we can avoid creating a `FileSet` for files that
contain a virus, and add error handling earlier in the stack. In this case, we
log to `Rails.logger.error`.

We also clean up the file from disk, which Hyrax does not seem to bother
with(?).

Closes #178.

449 of 794 relevant lines covered (56.55%)

0.62 hits per line

Source Files on job 1039.1 (2.4.2)
  • Tree
  • List 0
  • Changed 34
  • Source Changed 0
  • Coverage Changed 34
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Build 1039
  • Travis Job 1039.1
  • 2cdf5b81 on github
  • Prev Job for 2.4.2 on basic-virus-checking (#1035.1)
  • Next Job for 2.4.2 on basic-virus-checking (#1043.1)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc