xapi-project / sm / 498 / 1

47%

master: 47%

push

travis-ci

CA-218867: Handle exceptions and fail more elegantly

Added a catch for generic Exceptions in SRCommand.run(driver, driver_info).
This prints a xmlrpclib dump containing the details of the generic exception,
in the same way SR.SRExeption.toxml() does. In this way all unexpected errors
should be caught and printed in a syntax Xapi understands. A new error code
(1200) has also been defined in XE_SR_ERRORCODES.xml to broadly categorise
generic errors. Some tests have also been changed and updated to test throwing
exceptions in a more appropriate manner.

Signed-off-by: James Davis <james.davis1@citrix.com>
Reviewed-by: Mark Syms <mark.syms@citrix.com>

716 of 6302 branches covered (11.36%)

6655 of 20624 relevant lines covered (32.27%)

0.32 hits per line