1
97%
production: 97%

Ran 23 Jan 2018 04:38AM UTC

Files 25

Run time 2s

Badge

Embed ▾

Committed 23 Jan 2018 04:36AM UTC coverage: 98.582%. Remained the same

Job # 2.2.3

Build Type

push

travis-ci

Committed by

jszwedko

Commit Message

Switch from Haversine formula to earth_distance Postgres extension

More readible and solves the issues we had where the query lat/lng
resulting in a value outside of [1,-1] within ACOS() leading to an
error, "input is out of range". This appears to occur when the lat/lng
in the query exactly matches a thing's location. E.g.

```
SELECT
  ACOS(
    COS(RADIANS(37.7876114900295))
    * COS(RADIANS(37.78761149002950))
    * COS(RADIANS(-122.39915856367400) - RADIANS(-122.399158563674))
    + SIN(RADIANS(37.7876114900295))
    * SIN(RADIANS(37.78761149002950))
  )
;
```

Results in `ERROR:  input is out of range`.

I _think_ this is because of floating point imprecision because if we
remove the ACOS:

```
SELECT
  COS(RADIANS(37.7876114900295))
  * COS(RADIANS(37.78761149002950))
  * COS(RADIANS(-122.39915856367400) - RADIANS(-122.399158563674))
  + SIN(RADIANS(37.7876114900295))
  * SIN(RADIANS(37.78761149002950))
;
```

We get `1` which should give an `ACOS(1)` == `0`.

Coverage Stats

278 of 282 relevant lines covered (98.58%)

2.45 hits per line

sfbrigade / adopt-a-drain / 590 / 1
97%
production: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 590.1 (2.2.3)

sfbrigade / adopt-a-drain / 590 / 1 97% production: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 590.1 (2.2.3)

sfbrigade / adopt-a-drain / 590 / 1
97%
production: 97%

README BADGES
x