1
90%
master: 90%

Ran 28 Dec 2017 08:59PM UTC

Files 197

Run time 8s

Badge

Embed ▾

Committed 28 Dec 2017 08:42PM UTC coverage: 90.582%. Remained the same

Job # 2.3.4

Build Type

Pull #836

travis-ci

Committed by

web-flow

Commit Message

Make sure fields get marked as dirty if they change. Story #122

I overrode the getter and setter methods for the ordered fields to keep
track of their order in secondary fields, but that caused a problem.
Even though those fields appeared to be correct in the UI, I noticed
that the `description` and `ordered_descriptions` fields were out of
sync in the fedora console.

The overrides to the getters and setters messed up the logic that
determines whether or not a field is marked dirty.

I wrote a spec to make sure that both the original field and its
secondary ordering field will be marked dirty if the field is updated,
and then moved the `super` call to the top of the setter method, which
solves the problem with the logic for dirtiness.

Pull Request Pull Request #836: Make sure fields get marked as dirty if they change. Story #122

Coverage Stats

2741 of 3026 relevant lines covered (90.58%)

111.27 hits per line

curationexperts / epigaea / 2343 / 1
90%
master: 90%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2343.1 (2.3.4)

curationexperts / epigaea / 2343 / 1 90% master: 90%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2343.1 (2.3.4)

curationexperts / epigaea / 2343 / 1
90%
master: 90%

README BADGES
x