se-edu / addressbook-level4 / 3878 / 1
94%
master: 94%

DEFAULT BRANCH: master
Ran
Files 93
Run time 2s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 92.492% (+0.3%) from 92.194%
3878.1

push

travis-ci

web-flow 
Improve separation of concerns between parser/storage layer and model layer (#667)

The model classes Name, Email, Address, Phone and Tag perform input
validation and string trimming even though that is not the
responsibility of the model layer.

Fix this by moving the input validation and string trimming logic from
these classes to the parser/storage layer where they should rightfully
be.

  [1/15] TestUtil#assertThrows(...): support checked exceptions
  [2/15] NameTest, PhoneTest, EmailTest, AddressTest, TagTest: add missing null tests
  [3/15] XmlAdaptedPersonTest: add tests for #toModelType()
  [4/15] Move string trimming responsibility from Name to ParserUtil#parseName(String)
  [5/15] Move Name validation step from model to the parser and storage layers
  [6/15] Move string trimming responsibility from Phone to ParserUtil#parsePhone(String)
  [7/15] Move Phone validation step from model to parser and storage layers
  [8/15] Move string trimming responsibility from Address to ParserUtil#parseAddress(String)
  [9/15] Move Address validation step from model to parser and storage layers
  [10/15] Move string trimming responsibility from Email to ParserUtil#parseEmail(String)
  [11/15] Move Email validation step from model to parser and storage layers
  [12/15] Move string trimming responsibility from Tag to ParserUtil#parseTag(String)
  [13/15] Move Tag validation step from model to parser and storage layers
  [14/15] Remove unnecessary IllegalValueException catches and throws in code base
  [15/15] EditPersonDescriptorBuilder: simplify code by using model constructors

1466 of 1585 relevant lines covered (92.49%)

0.92 hits per line

Source Files on job 3878.1