• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

ICRAR / ngas / 144 / 1
69%
master: 69%

Build:
DEFAULT BRANCH: master
Ran 22 Dec 2017 03:05AM UTC
Files 159
Run time 5s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

22 Dec 2017 02:47AM UTC coverage: 62.377% (-0.02%) from 62.392%
DB=sqlite3

push

travis-ci

rtobar
Correctly supporting literal '%' in SQL queries

Our previous implementation didn't take into account that literal '%'
characters in SQL queries do not work in some drivers due to them using
the 'pyformat' or 'format' paramstyles. I haven't double-checked, but we
probably simply didn't have any query in the ngamsDb* modules that used
a literal '%' character, and only now that we added one in the
ngamsDataCheckingThreadTest module the problem became apparent.

This commit fixes the situation and properly replaces the percentage
characters with their escaped version when necessary. We are also now
centralizing the formatting of both the SQL query and the parameters so
we don't need to repeat the same logic in two places.

Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>

12630 of 20248 relevant lines covered (62.38%)

0.62 hits per line

Source Files on job 144.1 (DB=sqlite3)
  • Tree
  • List 0
  • Changed 11
  • Source Changed 1
  • Coverage Changed 11
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Build 144
  • Travis Job 144.1
  • 71cee50d on github
  • Prev Job for DB=sqlite3 on master (#143.1)
  • Next Job for DB=sqlite3 on master (#145.1)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc