openconfig / ygot / 825 / 2
89%
master: 89%

DEFAULT BRANCH: master
Ran
Files 40
Run time 3s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 90.511% (-0.02%) from 90.527%
825.2

push

travis-ci

web-flow 
Fix a number of bugs related to enumerations within unions. (#140)

* Fix bug where a leafref key to a union that included an enum didn't add enum.

 * (M) ygen/codegen_test.go
  - Add a test case demonstrating the bug described below.
 * (M) ygen/protogen.go
  - When a list had a key that was a leafref, and path compression was
    disabled, and the target of the leafref was a union that contained
    a enumeration, then the enumeration would not be output within the
    list key message, meaning that it could not be resolved correctly.
    This PR fixes that behaviour to include the enum.
 * (A) testdata/proto/union-list-key*
  - Test case for the above setup.

* Squash bug with nested unions within proto messages.

 * (M) ygen/protogen.go
   - Squash a bug whereby nested unions that contained enumerations
     were not fully unrolled so that the embedded enum was not
     included in the relevant message.
 * (M) testdata/proto/union-list-key*
   - Write failing test cases to fix.

* Clean up unused files.

  * (M) ygen/codegen_test.go
    - Ensure consistency of naming for testdata files.
  * (R) ygen/testdata/proto/union-list-key.uncompressed.formatted-txt
    - Rename file such that it matches other files
  * (D) ygen/testdata/proto/union-list-key.uncompressed.enums.formatted-txt
  * (D) ygen/testdata/proto/union-list-key.uncompressed.union_list_key.formatted-txt
    - Remove stale test data.

* Fix test failures.

  * (M) ygen/codegen_test.go
  * (A) ygen/testdata/proto/union-list-key.union_list_key.formatted-txt
    - Fix tests referencing same file.

7030 of 7767 relevant lines covered (90.51%)

83.73 hits per line

Source Files on job 825.2