se-edu / addressbook-level4 / 3856 / 1
94%
master: 94%

DEFAULT BRANCH: master
Ran
Files 93
Run time 2s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 92.189% (+0.03%) from 92.159%
3856.1

push

travis-ci

web-flow 
Correctly model the scene graph hierarchy of MainWindow and HelpWindow (#747)

As their names suggest, the root object of MainWindow and HelpWindow
should be their Stage. However, this is presently not so. The root
object of MainWindow and HelpWindow are both Regions, and the Stage and
Scene which they manage is sneakily handled in their constructors.

This violates the architecture of the UiPart system, which dictates that
the return value of UiPart#getRoot(), as well as the root node of the
FXML file, should be the root object of the scene graph which the UiPart
manages. This derivation from the architecture may confuse readers.

Fix this by using the <fx:root> feature of FXML files to achieve the
aforementioned proper UiPart structure. The user interface from the
user's point of view does not change.

  [1/9] UiPart: allow callers to specify the scenegraph root
  [2/9] SystemTestSetupHelper: use a new primary stage for each application
  [3/9] MainWindow: make the primary Stage the root object
  [4/9] MainWindow: move icon, minHeight, minWidth definitions into the FXML file
  [5/9] HelpWindow: remove unneeded call to createDialogStage(...)
  [6/9] UiPart: remove createDialogStage(...)
  [7/9] HelpWindow: make its Stage the root object
  [8/9] HelpWindow: move title, maximized, icon definitions to its FXML file
  [9/9] FxViewUtil: remove #setStageIcon(Stage, String)

1428 of 1549 relevant lines covered (92.19%)

0.92 hits per line

Source Files on job 3856.1