Gallopsled / pwntools / 2963 / 1

74%

dev: 74%

push

travis-ci

Fix emulation of fault_addr (#1066)

As @bennofs noticed, our detection logic was incorrect:

"This is not a good test if I understand the issue correctly.

From my tests, it seems that fault_addr was only null before this patch if it
would've been >= 2**47.

This is because on 64 bit, that's where kernel memory is mapped so we get
"protection fault" instead of "segfault".

A protection fault does not have the same siginfo as a normal segfault:
si_code will be SI_KERNEL = 0x80 and there won't be a fault_addr

(see http://elixir.free-electrons.com/linux/v4.14-rc8/source/kernel/signal.c#L1052)"

2282 of 5267 branches covered (43.33%)

7949 of 13683 relevant lines covered (58.09%)

0.58 hits per line