1
63%
master: 63%

Ran 29 Nov 2017 04:19PM UTC

Files 7

Run time 0s

Badge

Embed ▾

Committed 29 Nov 2017 04:15PM UTC coverage: 62.456%. Remained the same

Job # 1961.1

Build Type

Pull #818

travis-ci

Committed by

web-flow

Commit Message

Refactor tests for process recycling

The test case in `pulp_smash.tests.pulp2.rpm.cli.test_process_recycling`
sets and unsets `PULP_MAX_TASKS_PER_CHILD` in
`/etc/default/pulp_workers`, and verifies that Pulp respects this option
when starting up. Unfortunately, this test case frequently fails on
Fedora 26, during step four. It's unclear why this test fails, and even
worse, the failure is a heisenbug.

Refactor this module:

* Expand the debugging messages in the assertions. This should make it
  easier to understand whether or not the test failures are significant,
  or if they're insignificant, such as due to a dying process living too
  long.
* Deduplicate clean-up logic in the test case, and make clean-up more
  robust in the case of unexpected failures.
* Drop a function for restarting services, in favor of function
  `GlobalServiceManager.restart`.
* Make "sudo" logic more concise.
* Pre-split strings, to ensure no whitespace surprises.

Pull Request Pull Request #818: Refactor tests for process recycling

Run Details

529 of 847 relevant lines covered (62.46%)

0.62 hits per line

PulpQE / pulp-smash / 1961 / 1
63%
master: 63%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1961.1

PulpQE / pulp-smash / 1961 / 1 63% master: 63%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1961.1

PulpQE / pulp-smash / 1961 / 1
63%
master: 63%

README BADGES
x