vlm / asn1c / 628 / 1
71%
master: 71%

DEFAULT BRANCH: master
Ran
Files 63
Run time 3s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 71.52% (+0.1%) from 71.402%
TASK=check CONFIG_FLAGS="--enable-Werror --enable-test-Werror --enable-code-coverage"

Pull #234

travis-ci

web-flow 
Use comprehensible names for instances of parameterized types

With previous commit, the following data types are generated in ProtocolIE-Field.h
for S1AP's ASN.1 :

```
typedef enum ProtocolIE_Field_6564P0__value_PR {
    ProtocolIE_Field_6564P0__value_PR_NOTHING, /* No components present */
    ProtocolIE_Field_6564P0__value_PR_E_RABToBeSetupItemBearerSUReq
} ProtocolIE_Field_6564P0__value_PR;

typedef struct ProtocolIE_Field_6564P0 {
    ProtocolIE_ID_t      id;
    Criticality_t        criticality;
    struct ProtocolIE_Field_6564P0__value {
        ProtocolIE_Field_6564P0__value_PR        present;
        union ProtocolIE_Field_6564P0__value_u {
            E_RABToBeSetupItemBearerSUReq_t      E_RABToBeSetupItemBearerSUReq;
        } choice;

        /* Context for parsing across buffer boundaries */
        asn_struct_ctx_t _asn_ctx;
    } value;

    /* Context for parsing across buffer boundaries */
    asn_struct_ctx_t _asn_ctx;
} ProtocolIE_Field_6564P0_t;

```

It's difficult for developer to recognize to which ASN.1 type they are linked.
They all start with 'ProtocolIE_Field_'. It will be error-prone.

With this commit, more human comprehensible data types are generated :

```

typedef enum E_RABToBeSetupItemBearerSUReqIEs_6564P0__value_PR {
    E_RABToBeSetupItemBearerSUReqIEs_6564P0__value_PR_NOTHING, /* No components present */
    E_RABToBeSetupItemBearerSUReqIEs_6564P0__value_PR_E_RABToBeSetupItemBearerSUReq
} E_RABToBeSetupItemBearerSUReqIEs_6564P0__value_PR;

typedef struct E_RABToBeSetupItemBearerSUReqIEs_6564P0 {
    ProtocolIE_ID_t      id;
    Criticality_t        criticality;
    struct E_RABToBeSetupItemBearerSUReqIEs_6564P0__value {
        E_RABToBeSetupItemBearerSUReqIEs_6564P0__value_PR present;
        union E_RABToBeSetupItemBearerSUReqIEs_6564P0__value_u {
            E_RABToBeSetupItemBearerSUReq_t               E_RABToBeSetupItemBearerSUReq;
        } choice;

        /* Context for parsing across buffer boundaries */... (continued)
Pull Request #234: Fix s1ap code generation (2nd pull reuqest)

8129 of 11366 relevant lines covered (71.52%)

28294.11 hits per line

Source Files on job 628.1 (TASK=check CONFIG_FLAGS="--enable-Werror --enable-test-Werror --enable-code-coverage")