keathley / wallaby / 930 / 9
85%
master: 85%

DEFAULT BRANCH: master
Ran
Files 33
Run time 3s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 36.967% (-1.4%) from 38.337%
WALLABY_DRIVER=selenium WALLABY_SELENIUM_VERSION=3

push

travis-ci

web-flow 
Fixes zombie phantomjs (#325)

* Fix zombie phantom process

This commit contains several high level changes to solve the zombie
phantom process issue.

1. New ProcessWorkspace helper which creates a temporary folder for that
is available for the life of the given processes. This folder is a great
place for writing the process wrapper script, creating local storage
folders, etc. This folder is automatically deleted when the attached
process exits. These folders weren't previously getting cleaned up.

2. Improved run_phantom.sh wrapper script. This script now handles
shutting down when STDIN is closed, shuts down when it receives a INT,
HUP, or TERM signal, and shuts down when the underlying program crashes.
Since phantom spawns several child processes, this script also waits
until all child processes have exited before it exits itself. This helps
prevent Wallaby's ProcessWorkspace from deleting the wrapper script and
other temporary files before a phantomjs instance has fully shut down.

3. New tests to ensure that the Phantom.Server process responds as we'd
expect in the various crashing situations. I also made the wrapper
script echo back the PID of the phantom process so we can kill the
underlying phantom process as well.

There is a slight race condition where we can get zombie processes if we
shutdown the Phantom.Server process before it's had a chance to fully
start and wait for STDIN to close.

* Wait in Server.init/1 until phantom is started

Although multiple servers aren't started at the same time, this makes
sure that phantom is completely started before returning from init and
prevents zombie processes that occur when shutting down before the
script is completely started.

312 of 844 relevant lines covered (36.97%)

6226.05 hits per line

Source Files on job 930.9 (WALLABY_DRIVER=selenium WALLABY_SELENIUM_VERSION=3)