• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Devex / article_json / 234 / 1
100%
master: 100%

Build:
DEFAULT BRANCH: master
Ran 11 Oct 2017 03:17PM UTC
Files 120
Run time 5s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

11 Oct 2017 03:15PM UTC coverage: 100.0%. Remained the same
2.3

push

travis-ci

dsager
Add `custom_element_tags` to AMP exporter and refactor library lookup

By adding `ArticleJSON::Export::AMP::Exporter#custom_element_tags`
the user can now get a list of all used libraries (e.g. to check if one
should manually include an additional `iframe` library for an element
used outside of the article).

By refactoring the logic like this, we now also no longer need to parse
the AMP element before being able to get a list of all its required
custom elements.

The specs for `ArticleJSON::Export::AMP::Exporter.amp_libraries` still
pass (only some spacing had to be fixed). Therefore, the (tested) API of
the class remains the same.

`ArticleJSON::Export::AMP::Elements::Base.amp_library` (was untested)
has been removed and replaced with `.custom_element_tags` which now
returns a list of all custom tags used by the element.

2870 of 2870 relevant lines covered (100.0%)

16.61 hits per line

Source Files on job 234.1 (2.3)
  • Tree
  • List 0
  • Changed 22
  • Source Changed 7
  • Coverage Changed 22
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Build 234
  • Travis Job 234.1
  • 6810dc0e on github
  • Prev Job for 2.3 on master (#227.1)
  • Next Job for 2.3 on master (#236.1)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc