• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

mvdan / sh / 889 / 2
78%
master: 78%

Build:
DEFAULT BRANCH: master
Ran 02 Oct 2017 12:37PM UTC
Files 20
Run time 1s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

02 Oct 2017 12:33PM UTC coverage: 94.351% (-0.01%) from 94.361%
889.2

push

travis-ci

mvdan
syntax: parse valid parameter names only

When parsing $foo. We stopped on certain characters, i.e. a blacklist.
Yet the POSIX spec says the opposite:

	If the parameter is not enclosed in braces, and is a name, the
	expansion shall use the longest valid name (see XBD Name)

In other words, we should use a whitelist of characters that are allowed
to advance the lexer. This means that we should stop on any symbol and
any non-ASCII letter, for example. Do it this way and add more tests.

This also means we can simplify quite a bit of the code dealing with
these in the ever growing advanceLitOther.

5562 of 5895 relevant lines covered (94.35%)

961.51 hits per line

Source Files on job 889.2
  • Tree
  • List 0
  • Changed 7
  • Source Changed 2
  • Coverage Changed 7
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Build 889
  • Travis Job 889.2
  • c32e0986 on github
  • Prev Job for on master (#888.1)
  • Next Job for on master (#890.1)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc