Kibibit / achievibit / 331 / 1

39%

develop: 100%

push

travis-ci

OAuth server side functions (#96)

* add+update user; create\delete webhook

* create two api end-points

one to authenticate and another one to create\delete webhooks

(currently I'm sending the githubToken to the client and it sends it back when creating a webhook. need to keep only the firebaseToken on the client side

* install missing dependency for firebase-admin

* Simplify our console service to create defaults (show time and location)

* change consoleService call

* change consoleService call + fix status warning + add missing code

currently, written as a comment since I need to also import the **account key** in some fancy way

* move consoleService into app/models folder

* implement api functions inside files

* add api file

* use api file inside index.js

* ignore mocha reports

* NEVER save private config file

private config file should make it easier to save configuration to disk (DB url, etc)

* save and require Q in our project (missing previous commit)

* change order in api so routes won't override other routes

* create new configuration service

this will handle all configurations (also will save the configuration you add as argv if you add --savePrivate)

I still need to make this simpler, but it's already simpler than the previous one :-)

* use new configService + uncomment firebase admin initialization

* put savePrivate inside configurationService

* remove traces of nconf in other files

* lint

* make sure `updateWith` object is defined

* get the firebase admin from userService

later, should replace this with a function that does this internally

* expose authenticateUsingToken instead of the defaultAuth object

* also use authenticateUsingToken internally for tests

* basic structure for userService specs

I want to change the functions inside userService to not use req and res so that it will be simpler to test.

after that change, I'll change this to test the actual file and not the function I mocked a few lines before :-)

* iif not all firebase admin vars are set, don't authenticate

* change userService model structure to support easier tests

* write mocks to help test individual files

* add some tests for userService auth functions

* comment out e2e and check how to fix the tests timing-out

104 of 437 branches covered (23.8%)

373 of 956 relevant lines covered (39.02%)

1.72 hits per line