• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Algo-Web / POData-Laravel / 497 / 1
100%
master: 100%

Build:
DEFAULT BRANCH: master
Ran 25 Sep 2017 03:59PM UTC
Files 25
Run time 2s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

25 Sep 2017 03:56PM UTC coverage: 99.791%. Remained the same
LARAVEL_DEP=5.1.*

push

travis-ci

web-flow
Fix PrimaryKey substitution in LaravelReadQuery (#117)

When applying a non-trivial orderBy object that contained PrimaryKey
field, getResourceSet was ignoring previously-retrieved copy of target
model's primary key and trying to dig it out anew.  This doesn't work
too well on query builders, as getKeyName doesn't exist.

The simple and obvious fix is to simply cut the orderBy handling over
to use the previously-retrieved copy of keyName, and let it worry about
whether we're hanging off a model, relation, etc.

2393 of 2398 relevant lines covered (99.79%)

36.24 hits per line

Source Files on job 497.1 (LARAVEL_DEP=5.1.*)
  • Tree
  • List 0
  • Changed 7
  • Source Changed 1
  • Coverage Changed 7
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Build 497
  • Travis Job 497.1
  • 9e0fa341 on github
  • Prev Job for LARAVEL_DEP=5.1.* on master (#494.1)
  • Next Job for LARAVEL_DEP=5.1.* on master (#499.1)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc