bradleyfalzon / revgrep / 40 / 1

84%

master: 84%

Pull #12

travis-ci

<a href="https://github.com/bradleyfalzon/revgrep/commit/<a class=hub.com/bradleyfalzon/revgrep/commit/b18d32aa36f5a7215a458728cca5fbf6bfff2f50">b18d32aa3<a href="https://github.com/bradleyfalzon/revgrep/commit/b18d32aa36f5a7215a458728cca5fbf6bfff2f50">&quot;&gt;Fix bug where file with only removed lines was being detected as new

Checker.linesChanged returns a map of files and a slice of positions
that have changed. If the slice was nil, it was an indication that
the file was new, so any issues found in that file were new and should
be raised. But if the file only had lines that were removed (not added
or modified), the slice would also be new.

This change introduces a third state, where an empty slice would indicate
no lines have been added (or modified).

I don&amp;#39;t think this is an ideal change, the bug was likely introduced
in </a><a class="double-link" href="https://github.com/bradleyfalzon/revgrep/commit/<a class="double-link" href="https://github.com/bradleyfalzon/revgrep/commit/8d3df443d0743c5b4346687e60ae485d75fbe3be">8d3df443d</a>">8d3df443d</a><a href="https://github.com/bradleyfalzon/revgrep/commit/b18d32aa36f5a7215a458728cca5fbf6bfff2f50">, where previous to that
new files had an artificial diff created indicating all lines were
added. That commit was designed to remove the external dependency in
GNU diff.

I&#39;ve settled on this change simply because it&#39;s straight forward and
doesn&#39;t add another dependency, but I&#39;m not convinced it&#39;s the best
change either.

There&#39;s other related issues to this, some tools may want to see issues
on lines that have been removed, such as apicompat, a larger change
may want to take this into account.

Related to https://github.com/bradleyfalzon/gopherci/issues/86.
Related to https://github.com/bradleyfalzon/gopherci/issues/63.

169 of 238 relevant lines covered (71.01%)

18.67 hits per line