2
46%
master: 46%

Ran 12 Sep 2017 01:00PM UTC

Files 66

Run time 4s

Badge

Embed ▾

Committed 12 Sep 2017 12:56PM UTC coverage: 63.85% (+0.1%) from 63.733%

Job # TOX_ENV=py34

Build Type

push

travis-ci

Committed by

RobRuana

Commit Message

Fix #1578, use phonenumbers library for validation (#2858)

* Use Google's phone number library for validation

Fixes #1578

* Simplify error messages for phone validation

The phonenumbers library can easily handle international numbers, so we
should feel free to encourage users to input them. Therefore, there
does not appear to be any meaningful difference between the two states
of COLLECT_FULL_ADDRESS. This commit combines the two messages.

We use past tense here rather than an imperative, because this error
case only occurs if the user has already entered a value.

* Add phonenumbers 8.8.1 to requirements.txt

* Ensure US phone numbers contain area code

This adds a condition to _invalid_phone_number, ensuring that US phone
numbers contain an area code. The phonenumbers library considers 7-digit
US numbers to be acceptable, which is technically correct, but not what
we want here.

This commit also adds comments to this function.

* Add unit test for phone number validation

This adds basic test coverage over our phone number validation. We test
simple numbers, US and international

Coverage Stats

5426 of 8498 relevant lines covered (63.85%)

0.64 hits per line

magfest / ubersystem / 4266 / 2
46%
master: 46%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4266.2 (TOX_ENV=py34)

magfest / ubersystem / 4266 / 2 46% master: 46%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4266.2 (TOX_ENV=py34)

magfest / ubersystem / 4266 / 2
46%
master: 46%

README BADGES
x