2
61%
main: 61%

Ran 11 Sep 2017 05:44AM UTC

Files 21

Run time 1s

Badge

Embed ▾

Committed 11 Sep 2017 05:39AM UTC coverage: 75.962% (-0.1%) from 76.079%

Job # 775.2

Build Type

push

travis-ci

Committed by

deepakjois

Commit Message

Use mmap for reading values everywhere.

This change adds support for mmap-ing the writable value log file,
in addition to the read-only files. We mmap the files with the size
set to math.MaxUint32, which is the theoretical maximum size of the value
pointer offset.

It is not very clear what the implications of mmap-ing beyond the
size of the file is. The mmap manpage does not indicate anything
specific. Moreover, it also says:

> “The effect of changing the size of the underlying file of a mapping
on the pages that correspond to added or removed regions of the
file is unspecified.”

The approach used here is similar to what BoltDB is doing, so there
is some confidence that it is fine.

Other notable changes:

* Since we are doing mmap reads exclusively, we no longer need to
  pass around a slice to copy the buffer. So some method signatures
  also changed as a result of that.

* Rename logFile.fdlock to logFile.lock because it is now used to guard
both file descriptor and the memory map.

* Add logFile.mmap() convenience method.

* Make logFile.readValueBytes() method take a callback for consuming
bytes.

Coverage Stats

3138 of 4131 relevant lines covered (75.96%)

33108.61 hits per line

dgraph-io / badger / 775 / 2
61%
main: 61%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 775.2

dgraph-io / badger / 775 / 2 61% main: 61%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 775.2

dgraph-io / badger / 775 / 2
61%
main: 61%

README BADGES
x