• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

PulpQE / pulp-smash / 1772 / 2
63%
master: 63%

Build:
DEFAULT BRANCH: master
Ran 07 Sep 2017 05:32PM UTC
Files 7
Run time 0s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

07 Sep 2017 05:17PM UTC coverage: 62.204%. Remained the same
1772.2

push

travis-ci

Ichimonji10
Fix make targets for publishing Pulp Smash

The "package" make target is phony, meaning that it always triggers
packaging logic, even if packages already exist. This is problematic: if
one runs the "package" make target twice in a row, it will produce brand
new packages.

While this may seem like a good thing, it's actually problematic. If one
calls `scripts/release.sh` and the resultant package(s) are verified as
being good quality, then the "publish" make target shouldn't overwrite
those verified-good packages. It's true that the packaging process
should produce identical packages every time. But why overwrite
something that's known to be good, and for no good reason?

Rename the "package" make target to "dist," and make it a regular make
target instead of a phony one. As a result of this change, the packaging
make target no longer overwrites existing packages.

525 of 844 relevant lines covered (62.2%)

0.62 hits per line

Source Files on job 1772.2
  • Tree
  • List 0
  • Changed 0
  • Source Changed 0
  • Coverage Changed 0
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Build 1772
  • Travis Job 1772.2
  • f9deaea5 on github
  • Prev Job for on master (#1770.3)
  • Next Job for on master (#1792.3)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc