seyi-adeleke / Docman / 127 / 1

91%

master: 91%

push

travis-ci

Feedback (#33)

* linter(line spaces) :

Lines spacing should be at a maximum of 80 chars

* Unused packages should be removed

* Documentation(slate): The Api documentation should be in a folder called `documentation`

* Delete unused files

* Refactor(helpers) : Helper functions should be exported connsistently

* refactor(tests): Tests were refactored to adequately test new changes to the codebase

* Refactor(linter):

Code was refactored to maintain a proper max length of less than 80 characters

* Refactor(dates):

Dates should be saved in an easily readable format

* Refactor(validation)

Certain edge cases should be handled and return an appropriate response

* Refactor:

Users should be able to get a list of all publicly available documents

* Refactor helpers

* Refactor:

Repipe test coverage

* Bug(hound)

Hound should be ablt to work with eslint

* helpers (validation)

Abstracted the id validation into a helper

* Chore(tests)

Expected tests to return the appropriate response message

* Models

Added Validation to models and migrations

* Bugs(create)

Returns a readable mesage when a user tries to create a document with the wrong access level

Users cannot create multiple documents with same title

When users search for documents the appropriate response is returned

* Bug(roles)

When an admin tries to change the role of a user that doesnt exist an error message is returned

* Documentation

Refactored the documentation to reflect the new responses and added the status codes used in the api

* chore(hound)

Disabled hound

* documentation

Added The title to the documentation

* Bug(documents)

Returns an error message when a user tries to update a document to one that already exists

* chore(tests)

Added tests for new functionality

* Bug(users)

Returns an error message when a user tries to update their email to an email that already exists

* Refactor(tests)

Tests should suffeiceintly describe what is being tested

* Refactor(Utitilites)

Utilities should use es6 syntax and have jsdoc comments that adequately explain their function

* Configure hound

* tests(models)

Models should be unit tested in isolation

* Code cleanup

* Refactor(controllers)

Controllers should respect the DRY principle and error messages should be well formatted

* merge

* removed  autogenerated git lines

211 of 239 branches covered (88.28%)

Branch coverage included in aggregate %.

355 of 382 relevant lines covered (92.93%)

5.27 hits per line