TykTechnologies / tyk / 2748 / 2

Ran 09 Aug 2017 02:59PM UTC

Files 84

Run time 6s

Badge

Embed ▾

Committed 09 Aug 2017 02:54PM UTC coverage: 43.818% (+0.08%) from 43.738%

Job # LATEST_GO=true

Build Type

push

travis-ci

Committed by

buger

Commit Message

revproxy: don't append paths if we switched URLs

Because if we did, we may end up with a duplicate path.

We already partially fixed this with a path string comparison. However,
after some debugging, it was discovered that under some circumstances,
paths may be of the form "path" instead of "/path".

Use a stronger logic, and add tests for all combinations of RetainHost
and unexpected paths.

Reproducing the issue manually, before and after:

        DEBUG Outbound Request: http://192.168.0.148:8888/_count/_count

        DEBUG Outbound Request: http://192.168.0.148:8888/_count

Also move the scheme and host swapping, as they too modify req.URL when
it's already final. Although these were harmless, as they were replacing
instead of appending.

Fixes #962.

Coverage Stats

5947 of 13572 relevant lines covered (43.82%)

0.47 hits per line

TykTechnologies / tyk / 2748 / 2

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2748.2 (LATEST_GO=true)

TykTechnologies / tyk / 2748 / 2

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2748.2 (LATEST_GO=true)

README BADGES
x