mysociety / alaveteli / 7004 / 3

38%

develop: 38%

push

travis-ci

<a href="https://github.com/mysociety/alaveteli/commit/<a class=hub.com/mysociety/alaveteli/commit/5f45fff0c02fd7c426f3239e249ba51a164f8043">5f45fff0c<a href="https://github.com/mysociety/alaveteli/commit/5f45fff0c02fd7c426f3239e249ba51a164f8043">&quot;&gt;Override the user name param with the attribute value before update

Fixes broken spec:

  ./spec/integration/admin_user_controller_edit_spec.rb:19

Since upgrading to Rails 4.2, the value for User#name for a banned
user is always supplied with the &amp;quot;(Account suspended)&amp;quot; suffix so
when updating user account details via a form, the supplied params
include &amp;quot;Name (Account suspended)&amp;quot; which causes the name and url_name
to be updated in the database.

The change that caused this is
https://github.com/rails/rails/commit/</a><a class="double-link" href="https://github.com/mysociety/alaveteli/commit/<a class="double-link" href="https://github.com/mysociety/alaveteli/commit/3e74db6361cf61434fa47f44fcbccf50ce02bad8">3e74db636</a>">3e74db636</a><a href="https://github.com/mysociety/alaveteli/commit/5f45fff0c02fd7c426f3239e249ba51a164f8043">.

At the point of rendering the form `value_came_from_user?(object)`
returns `false` so we end up with the suffix applied.

9851 of 10592 relevant lines covered (93.0%)

638.3 hits per line