1
88%
dev: 88%

Ran 03 Aug 2017 11:51PM CUT

Files 44

Run time 2s

Badge

Embed ▾

Committed 03 Aug 2017 11:47PM CUT coverage: 88.394% (+0.4%) from 87.955%

Job # 3326.1

Build Type

push

travis-ci

Committed by

prashantv

Commit Message

Add tchannel.WithoutHeaders (#637)

This adds a function `tchannel.WithoutHeaders` (name TBD), which hides
TChannel Go-specific information from a Context.

This is needed to alleviate the following issue:

Existing TChannel Go services have been using the standard header
propagation behavior of TChannel Go (incoming headers are copied to
outgoing headers) happily and they start using YARPC+TChannel, or a
library that uses YARPC, to make outgoing calls to a different service.

Their expectation would be to have the headers copied over to that
outgoing call, especially if the underlying transport is TChannel. This
will not be supported in YARPC.

That leaves us with two options: silently ignore TChannel headers, or
reject outgoing requests made with TChannel contexts.

If we silently ignore TChannel headers, service owners who rely on this
behavior will suddenly start seeing hard-to-debug breakages. The number
of support tickets for this will be huge.

A better option is for YARPC to reject TChannel contexts on **all**
transports. YARPC will recommend that users remove the header
information from the context (with the use of `tchannel.WithoutHeaders`)
before passing it to YARPC. In the short-term, this adds a little work
for existing TChannel services but in the long run it saves them a lot
of time in terms of debugging.

Run Details

4364 of 4937 relevant lines covered (88.39%)

5977.56 hits per line

Source Files on job 3326.1

Show entries

Search:

Coverage	File	Lines	Relevant	Covered	Missed	Hits/Line
0.0	retryon_string.go	17 - 104	5 - 52	0 - 54	5 + 2	0.0 - 17
0.0	reqresreaderstate_string.go	17 - 75	5 - 41	0 - 37	5 - 4	0.0 - 5
0.0	reqreswriterstate_string.go	17 + 13	5 + 5	0	5 + 5	0.0
16.67	stats.go	62 + 50	12 + 6	2 - 3	10 + 9	4940.0 + 4939
37.5	frame_pool.go	87 + 80	24 + 20	9 + 5	15 + 15	23355.0 + 23354
54.39	localip.go	113 + 20	57 + 13	31 - 13	26 + 26	5.0 - 114
66.67	connectionstate_string.go	18 - 52	6 - 34	4 - 25	2 - 9	2502.0 + 2500
66.67	channelstate_string.go	18 - 178	6 - 78	4 - 65	2 - 13	1029.0 + 923
68.42	checksum.go	176 + 146	57 + 41	39 + 34	18 + 7	34289.0 + 34288
75.0	connection_direction.go	42 + 20	8 - 3	6	2 - 3	11378.0 + 11377

Showing 1 to 10 of 44 entries

uber / tchannel-go / 3326 / 1
88%
dev: 88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3326.1

uber / tchannel-go / 3326 / 1 88% dev: 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3326.1

uber / tchannel-go / 3326 / 1
88%
dev: 88%

README BADGES
x