3
82%
master: 81%

Ran 21 Jul 2013 05:05AM UTC

Files 13

Run time –

Badge

Embed ▾

Committed 21 Jul 2013 05:05AM UTC coverage: 96.701%. Remained the same

Job # 1.9.3

Build Type

push

travis-ci

Committed by

myronmarston

Commit Message

Convert Metadata to use composition rather than inheritance.

- It's best to avoid subclassing core types like Hash.
- Remove runtime module extensions, since that blows MRIs method
  caches and has an affect on perf.
- Instantiation was a two part process: `.new` followed by `process`.
  Conceptually, these belong together, so switch to using a single
  method for instantiation.

Two gotchas I discovered:

- The `include` matcher didn't initially work properly with `Metadata`.
  It uses an `is_a?(Hash)` check to know how to treat the object.
  To solve this, we override `is_a?` to return true for Hash.
- `dup` didn't work as expected. `dup` is used to get a copy that can be
  modified without affecting the original; however, `dup` was simply
  duping the wrapping object, and each retained a reference to the same
  wrapped hash, causing changes on one to show up on the other. I override
  `dup` and `clone` to address this.

Run Details

469 of 485 relevant lines covered (96.7%)

21.35 hits per line

rspec / rspec-core / 1476 / 3
82%
master: 81%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1476.3 (1.9.3)

rspec / rspec-core / 1476 / 3 82% master: 81%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1476.3 (1.9.3)

rspec / rspec-core / 1476 / 3
82%
master: 81%

README BADGES
x