3
90%
master: 90%

Ran 12 Jul 2017 08:17PM UTC

Files 49

Run time 2s

Badge

Embed ▾

Committed 12 Jul 2017 08:07PM UTC coverage: 90.646% (+0.01%) from 90.634%

Job # TASKS="cobertura coveralls"

Build Type

push

travis-ci

Committed by

kageiit

Commit Message

CommentBuilder: Fix possible NPE (#227)

This fixes an NPE in isBuildFailingCoverageCheck if
coverageCheckSettings is unset. We saw the following failure in a build,

    java.lang.NullPointerException
            at com.uber.jenkins.phabricator.CommentBuilder.isBuildFailingCoverageCheck(CommentBuilder.java:120)
            at com.uber.jenkins.phabricator.CommentBuilder.processParentCoverage(CommentBuilder.java:104)
            at com.uber.jenkins.phabricator.BuildResultProcessor.processParentCoverage(BuildResultProcessor.java:103)
            at com.uber.jenkins.phabricator.PhabricatorNotifier.perform(PhabricatorNotifier.java:228)
            at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
            at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:779)
            at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:720)
            at hudson.model.Build$BuildExecution.post2(Build.java:186)
            at hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:665)
            at hudson.model.Run.execute(Run.java:1753)
            at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
            at hudson.model.ResourceController.execute(ResourceController.java:98)
            at hudson.model.Executor.run(Executor.java:405)

coverageCheckSettings is the only thing I see there that could be null.

Run Details

1318 of 1454 relevant lines covered (90.65%)

59.07 hits per line

uber / phabricator-jenkins-plugin / 851 / 3
90%
master: 90%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 851.3 (TASKS="cobertura coveralls")

uber / phabricator-jenkins-plugin / 851 / 3 90% master: 90%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 851.3 (TASKS="cobertura coveralls")

uber / phabricator-jenkins-plugin / 851 / 3
90%
master: 90%

README BADGES
x