TykTechnologies / tyk / 2546 / 1

Ran 06 Jul 2017 04:07PM UTC

Files 84

Run time 4s

Badge

Embed ▾

Committed 06 Jul 2017 04:01PM UTC coverage: 42.418% (-0.08%) from 42.495%

Job # LATEST_GO=true

Build Type

push

travis-ci

Committed by

buger

Commit Message

all: protect apisByID with a rwmutex

Like in the case of the global policies map, reloads may swap this map
while other goroutines are using it. Add a test too.

Fixes the following race report from the test without the fix:

	WARNING: DATA RACE
	Write at 0x0000018a9fd8 by goroutine 494:
	  github.com/TykTechnologies/tyk.loadApps()
	      /home/mvdan/go/src/github.com/TykTechnologies/tyk/api_loader.go:622 +0xa0d
	  github.com/TykTechnologies/tyk.loadSampleAPI()
	      /home/mvdan/go/src/github.com/TykTechnologies/tyk/api_test.go:45 +0xd5
	  github.com/TykTechnologies/tyk.TestReloadApisRace()
	      /home/mvdan/go/src/github.com/TykTechnologies/tyk/gateway_test.go:973 +0x7c
	  testing.tRunner()
	      /home/mvdan/tip/src/testing/testing.go:754 +0x16c

	Previous read at 0x0000018a9fd8 by goroutine 394:
	  github.com/TykTechnologies/tyk.TestReloadApisRace.func1()
	      /home/mvdan/go/src/github.com/TykTechnologies/tyk/gateway_test.go:969 +0x4e

Coverage Stats

5774 of 13612 relevant lines covered (42.42%)

0.46 hits per line

TykTechnologies / tyk / 2546 / 1

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2546.1 (LATEST_GO=true)

TykTechnologies / tyk / 2546 / 1

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2546.1 (LATEST_GO=true)

README BADGES
x