4
86%
master: 88%

Ran 04 Jul 2017 07:31PM UTC

Files 233

Run time 15s

Badge

Embed ▾

Committed 04 Jul 2017 07:11PM UTC coverage: 86.342%. First build

Job # TARGET=coverage

Build Type

push

travis-ci

Committed by

GeorgyKirichenko

Commit Message

Altering a space takes effect immediately.

Before this patch, the new space, created by alter specification,
would be put into space cache only after successful WAL write.

This behaviour is not linearizable: on a replica, the WAL is
played sequentially, and the order of events could differ from the
master.

Besides, it could crash, as demonstrated in gh-2074 test case.

Since we use a cascading rollback for all transactions on WAL
write error, it's OK to put a space into space cache
before WAL write, so that the new transactions apply to the new
space.

This patch does exsactly that.

All subsequent requests are executed against the new space.

This patch also removes on_replace trigger in the old space, since
all checks against the new tuple format are performed using the new
space.

Fixes #2074.

Coverage Stats

29655 of 34346 relevant lines covered (86.34%)

1098359.86 hits per line

tarantool / tarantool / 8534 / 4
86%
master: 88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 8534.4 (TARGET=coverage)

tarantool / tarantool / 8534 / 4 86% master: 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 8534.4 (TARGET=coverage)

tarantool / tarantool / 8534 / 4
86%
master: 88%

README BADGES
x