1
41%
master: 78%

Ran 28 Jun 2017 04:41PM UTC

Files 9

Run time 0s

Badge

Embed ▾

Committed 28 Jun 2017 04:39PM UTC coverage: 41.065% (+41.1%) from 0.0%

Job # 38.1

Build Type

push

travis-ci

Committed by

mcaskill

Commit Message

Iternal improvements to Translator

In order to fix/support choice messages, we need access to the message selector. Unfortunately, the selector is private under Symfony's `Translator` class. To circumvent this limitation, we need to define our own selector property and require from the constructor.

Changes:
- Added protected getter for the `LocalesManager` (for subclasses)
- Added setter/getter for the `MessageSelector`
- Added Symfony's `MessageSelector` to the service provider
- Updated `Translator` to use the manager's getter
- Changed visibility to protected for `isValidTranslation()` (for subclasses)
- Fixed choice message in `translateChoice()` and `translationChoice()`

Run Details

324 of 789 relevant lines covered (41.06%)

4.46 hits per line

locomotivemtl / charcoal-translator / 38 / 1
41%
master: 78%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 38.1

locomotivemtl / charcoal-translator / 38 / 1 41% master: 78%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 38.1

locomotivemtl / charcoal-translator / 38 / 1
41%
master: 78%

README BADGES
x