7
99%
master: 100%

Ran 18 Jul 2013 10:52PM UTC

Files 15

Run time –

Badge

Committed 18 Jul 2013 10:50PM UTC coverage: 99.284%. Remained the same

Job # jruby-19mode, LIBSODIUM_MIRROR="http://download.dnscrypt.org/libsodium/releases/libsodium-%s.tar.gz" LIBSODIUM_VERSION=0.4.2 LIBSODIUM_DIGEST=1a7901cdd127471724e854a8eb478247dc0ca67be549345c75fc6f2d4e05ed39

Build Type

push

travis-ci

Committed by

stouset

Commit Message

Rewrite Sodium::Buffer to use an FFI::Pointer rather than a String

This avoids nastiness like copying garbage collectors from copying our
memory all over, forcing us to lose control of it. More importantly, we
fix a nasty bug related to garbage collection. If you retain a pointer
to a Sodium::Buffer's bytes but not the buffer itself, the buffer can be
garbage collected at any time (clearing your bytes).

The new implementation removes Sodium::Buffer#to_str and replaces it
with Sodium::Buffer#to_ptr and Sodium::Buffer#to_s. to_ptr gives you the
actual memory pointer to do with as you like. to_s gives you the actual
String contents, at which point guarantees are no longer made as to our
ability to clear the memory pointed to by the string. It is the caller's
responsibility never to call to_s on sensitive data unless absolutely
necessary.

Run Details

416 of 419 relevant lines covered (99.28%)

11.96 hits per line

Source Files on job 175.7 (jruby-19mode, LIBSODIUM_MIRROR="http://download.dnscrypt.org/libsodium/releases/libsodium-%s.tar.gz" LIBSODIUM_VERSION=0.4.2 LIBSODIUM_DIGEST=1a7901cdd127471724e854a8eb478247dc0ca67be549345c75fc6f2d4e05ed39 )

stouset / sodium / 175 / 7
99%
master: 100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 175.7 (jruby-19mode, LIBSODIUM_MIRROR="http://download.dnscrypt.org/libsodium/releases/libsodium-%s.tar.gz" LIBSODIUM_VERSION=0.4.2 LIBSODIUM_DIGEST=1a7901cdd127471724e854a8eb478247dc0ca67be549345c75fc6f2d4e05ed39 )

stouset / sodium / 175 / 7 99% master: 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 175.7 (jruby-19mode, LIBSODIUM_MIRROR="http://download.dnscrypt.org/libsodium/releases/libsodium-%s.tar.gz" LIBSODIUM_VERSION=0.4.2 LIBSODIUM_DIGEST=1a7901cdd127471724e854a8eb478247dc0ca67be549345c75fc6f2d4e05ed39 )

stouset / sodium / 175 / 7
99%
master: 100%

README BADGES
x