1
63%
master: 66%

Ran 14 Jun 2017 12:20PM UTC

Files 218

Run time 11s

Badge

Embed ▾

Committed 13 Jun 2017 10:44PM UTC coverage: 64.615% (+0.01%) from 64.605%

Job # TR_ARCH=local GCOV=1

Build Type

push

travis-ci

Committed by

avagin

Commit Message

vma: Fix badly inherited FD in filemap_open

Previous patch (5a1e1aac) tried to minimize the amount of
open()s called when mmap()ing the files. Unfortunatley, there
was a mistake and wrong flags were compared which resulted in
the whole optimization working randomly (typically not
working).

Fixing the flags comparison revealed another problem. The
patch in question correllated with the 03e8c417 one, which
caused some vmas to be opened and mmaped much later than the
premap. When hitting the situation when vmas sharing their
fds are partially premapped and partially not, the whole
vm_open sharing became broken in multiple places -- either
needed fd was not opened, or the not needed left un-closed.

To fix this the context, that tracks whether the fd should
be shared or not, should be moved from collect stage to
the real opening loop. In this case we need to explicitly
know which vmas _may_ share fds (file private and shared)
with each other, so the sharing knowledge becomes spread
between open_filemap() and its callers. Oh, well...

Signed-off-by: Pavel Emelyanov <xemul@virtuozzo.com>
Signed-off-by: Andrei Vagin <avagin@virtuozzo.com>

Run Details

19714 of 30510 relevant lines covered (64.61%)

127053.48 hits per line

0x7f454c46 / criu / 901 / 1
63%
master: 66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 901.1 (TR_ARCH=local GCOV=1)

0x7f454c46 / criu / 901 / 1 63% master: 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 901.1 (TR_ARCH=local GCOV=1)

0x7f454c46 / criu / 901 / 1
63%
master: 66%

README BADGES
x