pvlib / pvlib-python / 916 / 4
96%
master: 96%

DEFAULT BRANCH: master
Ran
Files 30
Run time 1s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 91.763% (+0.03%) from 91.736%
CONDA_ENV=py35

push

travis-ci

wholmgren 
Safely calculate dni from dhi and ghi (#250)

* creating basic function to calculate DNI from GHI and DHI

* replace equation with new function for test purposes

* change types to satisfy type checks

* remove warning if new function is used

* adapt input and output of dni method

* adapt docstring to new inputs

* add clearsky method to correct calculated dni

* add cutoff method to correct calculated dni

* add logging warning and debug messages

* increase code quality

* remove non-ascii characters

* Remove user warning

* Replace input variable location by zenith and clearsky_dni

* Correct docstring

* Remove unnecessary calculation

* Correct negative DNI

Negative values of the calculated DNI will be set to zero or if the new
input value 'set_to_nan' is 'True' will be set to 'NaN'.

* Implement clearsky method

* Include tolerance factor for clearsky method and adapt function call in modelchain

* Enable set_to_nan in cutoff method

* Raise value error if chosen method does not exist

* Debugging info how many values needed correction

* Correct parameter types in docstring

* Correct test_complete_irradiance

* Remove debugging info

* Remove method and introduce new parameters for cutoff zenith angles

* Adapt docstring to new parameters

* Remove commented lines

* Adapt complete_irradiance definition of modelchain to new parameters in DNI calculation

* Add test function for DNI calculation

* Merge upstream changes on master

The only conflict was that both me and the upstream master added a test
at the end of a test file so the solution was easy: just take both.

* Add accidentally un-added files

I had a mishap which removed these files from being version controlled.
This should fix it.

* Remove kwargs from dni function

* Remove unnecessary dni_tmp

* Remove blank line at end of docstring

* Add max_dni to do calculation only once

* Correct comment

* Correct docstring for lower_cutoff_zenith

* Remove kwargs from complete_irradiance

* Correct docstrings

* Use same default value for clearsky_tolerance as in ModelChain

* Change names of lower_ and upper_cutoff_zenith and adapt docstring and comments

lower_cutoff_zenith is renamed to zenith_threshold_for_clearsky_limit
upper_cutoff_zenith is renamed to zenith_threshold_for_zero_dni

* add safely calculate dni from dhi and ghi (#250)

4902 of 5342 relevant lines covered (91.76%)

0.92 hits per line

Source Files on job 916.4 (CONDA_ENV=py35)