2
84%
master: 91%

Ran 25 May 2017 04:49AM UTC

Files 180

Run time 15s

Badge

Embed ▾

Committed 25 May 2017 03:56AM UTC coverage: 84.286%. First build

Job # 7912.2

Build Type

push

travis-ci

Committed by

samccone

Commit Message

😈 Fix disconnect promise race.

It is possible that we were resolving the gather chain before we had
disconnected. When manually launching and killing chrome this can race
and result in an error to the user.

This fixes that problem. \o/.

Fixes #2337

---

Test plan:

Run launcher with:

```ts
const lighthouse = require('lighthouse');

import {launch} from './chrome-launcher';

async function runLighthouse(url: string) {
  const opts = {
    chromeFlags: ['--headless'],
  };
  const chrome = await launch(opts);
  const flags = {
    output: 'json',
    port: chrome.port,
  };

  const results = await lighthouse(url, flags);

  process.on('uncaughtException', (e: any) => {
    console.log(e);
  });

  await chrome.kill();
  return results;
}

runLighthouse('https://example.com');
```

Without this patch, and then run it with the patch. Observe it now
working.

Run Details

4645 of 5511 relevant lines covered (84.29%)

922.39 hits per line

GoogleChrome / lighthouse / 7912 / 2
84%
master: 91%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 7912.2

GoogleChrome / lighthouse / 7912 / 2 84% master: 91%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 7912.2

GoogleChrome / lighthouse / 7912 / 2
84%
master: 91%

README BADGES
x